From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o0LHVaDq084894 for ; Thu, 21 Jan 2010 11:31:38 -0600 Date: Thu, 21 Jan 2010 12:32:37 -0500 From: Christoph Hellwig Subject: Re: [PATCH] xfstests: fix format string warnings in locktest.c Message-ID: <20100121173237.GA25322@infradead.org> References: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A69AC@cf--amer001e--3.americas.sgi.com> <1AB9A794DBDDF54A8A81BE2296F7BDFE012A69AE@cf--amer001e--3.americas.sgi.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1AB9A794DBDDF54A8A81BE2296F7BDFE012A69AE@cf--amer001e--3.americas.sgi.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Alex Elder Cc: Christoph Hellwig , xfs@oss.sgi.com On Thu, Jan 21, 2010 at 10:34:12AM -0600, Alex Elder wrote: > Alex Elder wrote: > > Christoph Hellwig wrote: > >> Signed-off-by: Christoph Hellwig > > > > Looks good. > > > > Reviewed-by: Alex Elder > > By the way, the content of this patch is already incorporated > in Dave's patch "[7/8] xfstests: fix printf warnings in loctest.c". > http://patchwork.xfs.org/patch/517/ Dave fixed the warnings not quite correctly, he switched from %d which was totally wrong to %lu which is only correct on some 64-bit architectures. %zd is the really correct format. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs