public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: bpm@sgi.com
To: Emmanuel Florac <eflorac@intellique.com>
Cc: xfs@oss.sgi.com
Subject: Re: nfs performance delta between filesystems
Date: Fri, 22 Jan 2010 12:38:48 -0600	[thread overview]
Message-ID: <20100122183848.GB28561@sgi.com> (raw)
In-Reply-To: <20100122185419.63ae6430@harpe.intellique.com>

Hey Emmanuel,

I did some research on this in April last year on an old, old kernel.
One of the codepaths I flagged:

nfsd_create
  write_inode_now
    __sync_single_inode
      write_inode
        xfs_fs_write_inode
	  xfs_inode_flush
	    xfs_iflush

There were small gains to be had by reordering the sync of the parent and
child syncs where the two inodes were in the same cluster.  The larger
problem seemed to be that we're not treating the log as stable storage.
By calling write_inode_now we've written the changes to the log first
and then gone and also written them out to the inode.  

nfsd_create, nfsd_link, and nfsd_setattr all do this (or do in the old
kernel I'm looking at).  I have a patchset that changes
this to an fsync so we force the log and call it good.  I'll be happy to
dust it off if someone hasn't already addressed this situation.

-Ben

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-01-22 18:37 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-01-22 17:54 nfs performance delta between filesystems Emmanuel Florac
2010-01-22 18:38 ` bpm [this message]
2010-01-22 20:46   ` Emmanuel Florac
2010-01-23 12:30   ` Dave Chinner
2010-01-25 15:04   ` Christoph Hellwig
2010-01-25 20:28     ` bpm
2010-01-25 20:40       ` Christoph Hellwig

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100122183848.GB28561@sgi.com \
    --to=bpm@sgi.com \
    --cc=eflorac@intellique.com \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox