From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/2] xfstests: rebuild aclocal.m4
Date: Sun, 24 Jan 2010 18:16:31 +1100 [thread overview]
Message-ID: <20100124071631.GH25842@discord.disaster> (raw)
In-Reply-To: <20100121112115.GA27634@infradead.org>
On Thu, Jan 21, 2010 at 06:21:15AM -0500, Christoph Hellwig wrote:
> On Thu, Jan 21, 2010 at 05:02:52PM +1100, Dave Chinner wrote:
> > The local m4 configuration has not been built in a long time.
> > Trying to rebuild it results in failures with dmapi library
> > detection and libxfs.h detection macros. Fix the errors and rebuild
> > it.
> >
> > Note: the new format for the aclocal.m4 file uses m4_include
> > directives which means it is much smaller th an before and won't
> > need updating unless we include new m4 macro files.
>
> Looks good, but shouldn't we create aclocal.m4 automocatically as part
> of make configure which generates the rest of the auto* stuff and stop
> having it checked into the git repository?
I'll do that as a separate patch - I'm not sure what is involved in
doing this yet. No need to hold up the automatic dependency changes
for this....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-24 7:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-21 6:02 [PATCH 0/2] xfstests: Automatic build dependencies Dave Chinner
2010-01-21 6:02 ` [PATCH 1/2] xfstests: rebuild aclocal.m4 Dave Chinner
2010-01-21 11:21 ` Christoph Hellwig
2010-01-24 7:16 ` Dave Chinner [this message]
2010-01-21 6:02 ` [PATCH 2/2] xfstests: Automatic build dependency calculations Dave Chinner
2010-01-21 11:24 ` Christoph Hellwig
2010-01-24 7:17 ` Dave Chinner
2010-01-27 19:25 ` Eric Sandeen
2010-01-27 20:17 ` Christoph Hellwig
2010-01-27 20:20 ` Eric Sandeen
2010-01-27 20:26 ` [PATCH] xfstests: fix compilation of iopat targets Christoph Hellwig
2010-01-27 20:29 ` Eric Sandeen
2010-01-27 22:57 ` [PATCH 2/2] xfstests: Automatic build dependency calculations Dave Chinner
2010-01-27 23:06 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100124071631.GH25842@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox