public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] repair: add missing newlines to scan.c
@ 2010-01-23 21:15 Eric Sandeen
  2010-01-25 10:03 ` Christoph Hellwig
  0 siblings, 1 reply; 2+ messages in thread
From: Eric Sandeen @ 2010-01-23 21:15 UTC (permalink / raw)
  To: xfs-oss

Commit c83b756da0dac727457022d88d2a0ace30a6dc09 added some new
do_warn's but omitted the "\n" leading to some pretty messy
output when we go down this path.

Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
---

diff --git a/repair/scan.c b/repair/scan.c
index c4d2825..85017ff 100644
--- a/repair/scan.c
+++ b/repair/scan.c
@@ -563,13 +563,13 @@ _("%s freespace btree block claimed (state %d), agno %d, bno %d, suspect %d\n"),
 
 			if (b == 0 || !verify_agbno(mp, agno, b)) {
 				do_warn(
-	_("invalid start block %u in record %u of %d btree block %u/%u"),
+	_("invalid start block %u in record %u of %d btree block %u/%u\n"),
 					b, i, name, agno, bno);
 				continue;
 			}
 			if (len == 0 || !verify_agbno(mp, agno, end - 1)) {
 				do_warn(
-	_("invalid length %u in record %u of %d btree block %u/%u"),
+	_("invalid length %u in record %u of %d btree block %u/%u\n"),
 					len, i, name, agno, bno);
 				continue;
 			}


_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] repair: add missing newlines to scan.c
  2010-01-23 21:15 [PATCH] repair: add missing newlines to scan.c Eric Sandeen
@ 2010-01-25 10:03 ` Christoph Hellwig
  0 siblings, 0 replies; 2+ messages in thread
From: Christoph Hellwig @ 2010-01-25 10:03 UTC (permalink / raw)
  To: Eric Sandeen; +Cc: xfs-oss

On Sat, Jan 23, 2010 at 03:15:33PM -0600, Eric Sandeen wrote:
> Commit c83b756da0dac727457022d88d2a0ace30a6dc09 added some new
> do_warn's but omitted the "\n" leading to some pretty messy
> output when we go down this path.

Looks good,


Reviewed-by: Christoph Hellwig <hch@lst.de>

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-01-25 10:02 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-01-23 21:15 [PATCH] repair: add missing newlines to scan.c Eric Sandeen
2010-01-25 10:03 ` Christoph Hellwig

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox