From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/7] xfs: Sort delayed write buffers before dispatch
Date: Mon, 25 Jan 2010 07:00:54 -0500 [thread overview]
Message-ID: <20100125120054.GE8595@infradead.org> (raw)
In-Reply-To: <1264400564-19704-5-git-send-email-david@fromorbit.com>
> @@ -1937,42 +1967,46 @@ xfs_flush_buftarg(
> xfs_buftarg_t *target,
> int wait)
> {
> - struct list_head tmp;
> - xfs_buf_t *bp, *n;
> + xfs_buf_t *bp;
> int pincount = 0;
> + LIST_HEAD(tmp_list);
> + LIST_HEAD(wait_list);
>
> xfs_buf_runall_queues(xfsconvertd_workqueue);
> xfs_buf_runall_queues(xfsdatad_workqueue);
> xfs_buf_runall_queues(xfslogd_workqueue);
>
> set_bit(XBT_FORCE_FLUSH, &target->bt_flags);
> - pincount = xfs_buf_delwri_split(target, &tmp, 0);
> + pincount = xfs_buf_delwri_split(target, &tmp_list, 0);
>
> /*
> - * Dropped the delayed write list lock, now walk the temporary list
> + * Dropped the delayed write list lock, now walk the temporary list.
> + * All I/O is issued async and then if we need to wait for completion
> + * we do that after issuing all the IO.
> */
> - list_for_each_entry_safe(bp, n, &tmp, b_list) {
> + list_sort(NULL, &tmp_list, xfs_buf_cmp);
> + while (!list_empty(&tmp_list)) {
> + struct xfs_buf *bp;
This now has a bp variable both in functionp-wide scope and a local one
here. Might be worth to decide for either style.
Otherwise looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-25 11:59 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 6:22 [PATCH 0/7] Delayed write metadata writeback V3 Dave Chinner
2010-01-25 6:22 ` [PATCH 1/7] xfs: Make inode reclaim states explicit Dave Chinner
2010-01-25 11:47 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 2/7] xfs: Use delayed write for inodes rather than async Dave Chinner
2010-01-25 11:53 ` Christoph Hellwig
2010-01-25 22:31 ` Dave Chinner
2010-01-26 7:28 ` Dave Chinner
2010-01-26 16:10 ` Christoph Hellwig
2010-02-01 22:59 ` Dave Chinner
2010-01-25 15:29 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 3/7] xfs: Don't issue buffer IO direct from AIL push Dave Chinner
2010-01-25 11:59 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 4/7] xfs: Sort delayed write buffers before dispatch Dave Chinner
2010-01-25 12:00 ` Christoph Hellwig [this message]
2010-01-26 4:13 ` Dave Chinner
2010-01-25 6:22 ` [PATCH 5/7] xfs: Use delay write promotion for dquot flushing Dave Chinner
2010-01-25 12:03 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 6/7] xfs: kill the unused XFS_QMOPT_* flush flags Dave Chinner
2010-01-25 12:04 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 7/7] xfs: xfs_fs_write_inode() can fail to write inodes synchronously Dave Chinner
2010-01-25 16:03 ` Christoph Hellwig
2010-01-26 4:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125120054.GE8595@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox