From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 5/7] xfs: Use delay write promotion for dquot flushing
Date: Mon, 25 Jan 2010 07:03:14 -0500 [thread overview]
Message-ID: <20100125120314.GF8595@infradead.org> (raw)
In-Reply-To: <1264400564-19704-6-git-send-email-david@fromorbit.com>
On Mon, Jan 25, 2010 at 05:22:42PM +1100, Dave Chinner wrote:
> xfs_qm_dqflock_pushbuf_wait() does a very similar trick to item
> pushing used to do to flush out delayed write dquot buffers. Change
> it to use the new promotion method rather than an async flush.
>
> Also, xfs_qm_dqflock_pushbuf_wait() can return without the flush lock
> held, yet the callers make the assumption that after this call the
> flush lock is held. Always return with the flush lock held.
>
> Signed-off-by: Dave Chinner <david@fromorbit.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
This also removes the last user of xfs_bawrite, so you might want to
kill it.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-25 12:02 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-25 6:22 [PATCH 0/7] Delayed write metadata writeback V3 Dave Chinner
2010-01-25 6:22 ` [PATCH 1/7] xfs: Make inode reclaim states explicit Dave Chinner
2010-01-25 11:47 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 2/7] xfs: Use delayed write for inodes rather than async Dave Chinner
2010-01-25 11:53 ` Christoph Hellwig
2010-01-25 22:31 ` Dave Chinner
2010-01-26 7:28 ` Dave Chinner
2010-01-26 16:10 ` Christoph Hellwig
2010-02-01 22:59 ` Dave Chinner
2010-01-25 15:29 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 3/7] xfs: Don't issue buffer IO direct from AIL push Dave Chinner
2010-01-25 11:59 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 4/7] xfs: Sort delayed write buffers before dispatch Dave Chinner
2010-01-25 12:00 ` Christoph Hellwig
2010-01-26 4:13 ` Dave Chinner
2010-01-25 6:22 ` [PATCH 5/7] xfs: Use delay write promotion for dquot flushing Dave Chinner
2010-01-25 12:03 ` Christoph Hellwig [this message]
2010-01-25 6:22 ` [PATCH 6/7] xfs: kill the unused XFS_QMOPT_* flush flags Dave Chinner
2010-01-25 12:04 ` Christoph Hellwig
2010-01-25 6:22 ` [PATCH 7/7] xfs: xfs_fs_write_inode() can fail to write inodes synchronously Dave Chinner
2010-01-25 16:03 ` Christoph Hellwig
2010-01-26 4:51 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100125120314.GF8595@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox