Re: [PATCH 2/2] xfstests: Automatic build dependency calculations

Christoph Hellwig
2010-01-21T11:23:25Z

> LINUX_TARGETS = xfsctl bstat t_mtab getdevicesize \
> - preallo_rw_pattern_reader preallo_rw_pattern_writer ftrunc trunc \
> - fs_perms testx looptest locktest unwritten_mmap \
> + ftrunc trunc fs_perms testx looptest locktest unwritten_mmap \
> bulkstat_unlink_test bulkstat_unlink_test_modified t_dir_offset \
> t_futimens
>
> +SUBDIRS =
> +
> LLDLIBS = $(LIBATTR) $(LIBHANDLE) $(LIBACL)
>
> ifeq ($(HAVE_XLOG_ASSIGN_LSN), true)
> @@ -27,6 +28,7 @@ endif
> IRIX_TARGETS = open_unlink
>
> ifeq ($(PKG_PLATFORM),linux)
> +PREALLO_TARGETS = preallo_rw_pattern_reader

What happens to the writer here? Before introducing more special cases
for this duplicates let me post my patch to make the file compiled more
normal, will send it out ASAP.

Otherwise looks good to me.