Re: [PATCH 2/2] xfstests: Automatic build dependency calculations

Dave Chinner
2010-01-27T22:56:59Z

On Wed, Jan 27, 2010 at 01:25:33PM -0600, Eric Sandeen wrote:
> Dave Chinner wrote:
> > Currently the xfstest builds do not have any automatic dependency
> > calculations. It relies on a separate make depend run to build or
> > update dependency information. It also relies on an external
> > makedepend binary. If that binary does not exist, the dependencies
> > do not get calculated.
> >
> > To remove the dependency on makedepend, gcc can be used instead as
> > it has a command to generate dependency information. This patch
> > changes the dependency rule building to use gcc.
> >
> > In case anyone uses an old (several years) gcc compiler or a
> > compiler that doesn't support gcc compatible dependency generation,
> > a new configure check is added to turn off dependency checking so
> > builds can still be done.
> >
> > To use the dependencies automatically, we need to use a special
> > include makefile directive to include the build dependencies into
> > the current makefile. Essentially once the dependencies are
> > calculated, they can be included into the makefile and make will
> > recalculate the build dependencies automatically based on that
> > information.
> >
> > Hence we get a build that automatically calculates and keeps
> > dependencies up to date without dependence on any external tools.
> >
> > Signed-off-by: Dave Chinner <david@fromorbit.com>
>
> seems to be some fallout from this at least on my F10 box:
>
> /usr/bin/makedepend: warning: ignoring option -Wall
> /usr/bin/makedepend: error: cannot open "no-strict-aliasing"
>
> also this change:
>
> - preallo_rw_pattern_reader preallo_rw_pattern_writer ftrunc trunc \
> - fs_perms testx looptest locktest unwritten_mmap \
> + ftrunc trunc fs_perms testx looptest locktest unwritten_mmap \
> bulkstat_unlink_test bulkstat_unlink_test_modified t_dir_offset \
>
> ...
>
>
> +PREALLO_TARGETS = preallo_rw_pattern_reader
>
> seems to have lost the build of preallo_rw_pattern_reader & writer.
>
> Was that stray, or what were you going for there?

I thought I fixed all that up after hch's patches went in. Bugger.
I'll try to get a few minutes at lunchtime to fix it.

Cheers,

Dave.
--
Dave Chinner
david@fromorbit.com