From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: routine to create scratch of certain size
Date: Sat, 30 Jan 2010 05:19:51 -0500 [thread overview]
Message-ID: <20100130101951.GA32695@infradead.org> (raw)
In-Reply-To: <4B621D89.8070800@sandeen.net>
On Thu, Jan 28, 2010 at 05:28:09PM -0600, Eric Sandeen wrote:
> This is needed for later enospc tests to be generic
>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
> ---
>
> diff --git a/common.rc b/common.rc
> index 97513cc..cf2662a 100644
> --- a/common.rc
> +++ b/common.rc
> @@ -237,6 +237,27 @@ _scratch_mkfs_options()
> echo $SCRATCH_OPTIONS $MKFS_OPTIONS $* $SCRATCH_DEV
> }
>
> +# arg 1 is size in bytes, arg 2 is (optional) blocksize
> +_scratch_mkfs_sized()
> +{
> + fssz=$1
> + bsz=$2
> + [ -z "$bsz" ] && bsz=4096
> + let blocks=$fssz/$bsz
> +
> + case $FSTYP in
> + xfs)
> + _scratch_mkfs_xfs -d size=$fssz -b size=$bsz 2>&1 >>$here/$seq.full
> + ;;
> + ext2|ext3|ext4)
> + /sbin/mkfs -t $FSTYP -- $MKFS_OPTIONS -b $bsz $SCRATCH_DEV $blocks 2>&1>>$here/$seq.full
> + ;;
> + *)
> + _notrun "Filesystem $FSTYP not supported in _scratch_mkfs_sized"
> + ;;
> + esac
> +}
Looks good, the only questions is why you're using $MKFS_OPTIONS for
extN, but not for xfs?
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-01-30 10:18 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-28 23:28 [PATCH] xfstests: routine to create scratch of certain size Eric Sandeen
2010-01-30 10:19 ` Christoph Hellwig [this message]
2010-01-30 16:03 ` Eric Sandeen
2010-02-03 1:54 ` [PATCH V2] " Eric Sandeen
2010-02-03 2:49 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100130101951.GA32695@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox