Re: [PATCH] xfstests 224: test aio hole-fill at 4g

Eric Sandeen
2010-01-30T19:45:04Z

Christoph Hellwig wrote:
> On Sat, Jan 30, 2010 at 12:31:26PM -0600, Eric Sandeen wrote:
>> These are the deps that I know xfstests has, to build and to run:
>>
>> BuildRequires: autoconf, libtool, xfsprogs-devel, e2fsprogs-devel
>> BuildRequires: libacl-devel, libattr-devel, libaio-devel
>>
>> Requires: bash, xfsprogs, xfsdump, perl, acl, attr, bind-utils
>> Requires: bc, indent, quota
>>
>> which isn't so bad...
>
> Doesn't seem to bad. Indent is afaik only needed for the weird 122 test
> which doesn't apply to non-xfs filesystems.

and FWIW, we do:

_require_command /usr/bin/indent

so it'll just not run if it's not there (the above was for an rpm
attempt I made, wishing to automatically pull in everything that
might possibly be needed.)

-Eric

>> I'm not sure an xfsprogs dependency is so onerous; plenty has depended
>> on e2fsprogs through the years and we've lived with that ;) But
>> the lag time for xfsprogs to use released xfs_io functionality is a
>> bit of a bummer.
>>
>> But I guess I don't have a great answer for who else uses xfs_io:
>
> I use xfs_io in lots various local scripts. It's a really handly
> tool for exercising some of the more weird I/O related syscalls.