Re: [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log

Christoph Hellwig
2010-02-04T16:09:41Z

On Thu, Feb 04, 2010 at 07:14:22PM +1100, Dave Chinner wrote:
> On Wed, Feb 03, 2010 at 05:55:45AM -0500, Christoph Hellwig wrote:
> > Actually I'll take this one back - the log buffers aren't delwri
> > so xfs_flush_buftarg probably only helped by timing or the
> > xfs_buf_runall_queues on xfslogd_workqueue. Need to think about
> > this a bit more.
>
> Can you point me at the bug report? IIRC I've seen this in the
> past where we freed the log before we've done all the correct
> shutdown processing and they got fixed by correcting the
> order of shutdown to ensure the log is idle before freeing
> it...

Yes, that I was going to look into next. The recent report
is http://bugzilla.kernel.org/show_bug.cgi?id=15150 and there's
also a very similar one from Ed Cashin <ecashin@coraid.com> in
mail archives from November.