From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>, xfs@oss.sgi.com
Subject: Re: [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log
Date: Thu, 4 Feb 2010 11:10:50 -0500 [thread overview]
Message-ID: <20100204161050.GB11206@infradead.org> (raw)
In-Reply-To: <20100204081422.GF5332@discord.disaster>
On Thu, Feb 04, 2010 at 07:14:22PM +1100, Dave Chinner wrote:
> On Wed, Feb 03, 2010 at 05:55:45AM -0500, Christoph Hellwig wrote:
> > Actually I'll take this one back - the log buffers aren't delwri
> > so xfs_flush_buftarg probably only helped by timing or the
> > xfs_buf_runall_queues on xfslogd_workqueue. Need to think about
> > this a bit more.
>
> Can you point me at the bug report? IIRC I've seen this in the
> past where we freed the log before we've done all the correct
> shutdown processing and they got fixed by correcting the
> order of shutdown to ensure the log is idle before freeing
> it...
Yes, that I was going to look into next. The recent report
is http://bugzilla.kernel.org/show_bug.cgi?id=15150 and there's
also a very similar one from Ed Cashin <ecashin@coraid.com> in
mail archives from November.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-02-04 16:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-01 22:08 [PATCH for-2.6.33] xfs: flush all log buffers in xlog_dealloc_log Christoph Hellwig
2010-02-03 10:55 ` Christoph Hellwig
2010-02-04 8:14 ` Dave Chinner
2010-02-04 16:10 ` Christoph Hellwig [this message]
2010-02-05 2:58 ` Dave Chinner
2010-02-05 11:35 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204161050.GB11206@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox