From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@sandeen.net>, xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] more reserved blocks fixups
Date: Thu, 4 Feb 2010 11:18:47 -0500 [thread overview]
Message-ID: <20100204161847.GA32102@infradead.org> (raw)
In-Reply-To: <20100128015817.GH15853@discord.disaster>
On Thu, Jan 28, 2010 at 12:58:17PM +1100, Dave Chinner wrote:
> On Wed, Jan 27, 2010 at 05:14:54PM -0600, Eric Sandeen wrote:
> > This mangles the reserved blocks counts a little more.
> >
> > 1) add a helper function for the default reserved count
> > 2) add helper functions to save/restore counts on ro/rw
> > 3) save/restore reserved blocks on freeze/thaw
> > 4) disallow changing reserved count while readonly
> >
> > for 2) - maybe better names (save_and_clear?)
> > for 4) - maybe allow, but change the _ro field instead?
> >
> > (TBH not tested yet but wondered if this seems sane)
>
> I was wondering if the save/restore could be encapsualted entirely
> within xfs_quiesce_attr(). i.e. save before the superblock write,
> restore directly after. That removes the need for a variable in
> the xfs_mount structure, and catches both remount,ro and freeze.
Seems like a bit fragile. But I think we want Eric's version
over yours for a start - we should have a clean filesystem not
only after remount,ro but also for a frozen filesystem.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-02-04 16:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-01-27 23:14 [PATCH, RFC] more reserved blocks fixups Eric Sandeen
2010-01-28 1:58 ` Dave Chinner
2010-02-04 16:18 ` Christoph Hellwig [this message]
2010-02-05 22:59 ` PATCH V2] " Eric Sandeen
2010-02-06 1:41 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100204161847.GA32102@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox