From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: xfsprogs: to -DDEBUG or not to -DDEBUG?
Date: Fri, 5 Feb 2010 13:31:34 +1100 [thread overview]
Message-ID: <20100205023134.GA11483@discord.disaster> (raw)
In-Reply-To: <4B6AFB83.1070309@sandeen.net>
On Thu, Feb 04, 2010 at 10:53:23AM -0600, Eric Sandeen wrote:
> Fedora, long ago, disabled debug in the xfsprogs specfile:
>
> http://cvs.fedoraproject.org/viewvc/F-12/xfsprogs/xfsprogs.spec?r1=1.5&r2=1.6
>
> * Wed Apr 20 2005 Dave Jones <davej@redhat.com>
> - Disable debug. (#151438)
>
> per this bug: https://bugzilla.redhat.com/show_bug.cgi?id=151438
>
> referencing this email thread:
>
> http://oss.sgi.com/archives/linux-xfs/2005-03/msg00038.html
> which no longer exists (grrrr) but is probably now here:
>
> http://oss.sgi.com/archives/xfs/2005-03/msg00416.html
>
> Fedora still builds with -DNDEBUG, but the upstream tarball has
> it on by default. I have seen several occasions where other
> distros had failing xfs_repairs which were "fixed" by disabling
> debug. I'd like to make a decision on whether DEBUG should be
> on or off by default for upstream releases. Any thoughts?
Personally I'd prefer the repair process to stop if it comes across
inconsistencies it can't handle. Ignoring them is as likely to "fix"
the crash as it is to corrupt the filesystem more.
On top of that we get bug reports when those problems are hit so
we can look into what caused the problem. We don't really have a
repair test suite that covers all the possible corruptions that
can occur, so we are kind of reliant on users reporting conditions
we've never had to handle before so we can fix them...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-02-05 2:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-04 16:53 xfsprogs: to -DDEBUG or not to -DDEBUG? Eric Sandeen
2010-02-05 2:31 ` Dave Chinner [this message]
2010-02-05 21:14 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205023134.GA11483@discord.disaster \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox