From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: make install in the brave new build system world
Date: Fri, 5 Feb 2010 22:17:41 +1100 [thread overview]
Message-ID: <20100205111741.GD11483@discord.disaster> (raw)
In-Reply-To: <20100205104414.GC11483@discord.disaster>
On Fri, Feb 05, 2010 at 09:44:14PM +1100, Dave Chinner wrote:
> On Fri, Feb 05, 2010 at 04:22:29AM -0500, Christoph Hellwig wrote:
> > When doing make install in xfsprogs I get a lot of spew like this:
....
> > b) for some reason the new silent make rules don't apply to this.
>
> That's something I can't answer off the top of my head. I'll have a
> look into it.
Try the patch below.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
xfsprogs: clean up make install build
The install targets did not get the silent treatment like the
normal build targets. Shut them up.
Signed-off-by: Dave Chinner <david@fromorbit.com>
---
Makefile | 9 ++++++---
include/buildrules | 4 ----
2 files changed, 6 insertions(+), 7 deletions(-)
diff --git a/Makefile b/Makefile
index 62c4258..31be846 100644
--- a/Makefile
+++ b/Makefile
@@ -107,13 +107,16 @@ install-dev: default $(addsuffix -install-dev,$(SUBDIRS))
install-qa: install $(addsuffix -install-qa,$(SUBDIRS))
%-install:
- $(MAKE) -C $* install
+ @echo "Installing $@"
+ $(Q)$(MAKE) $(MAKEOPTS) -C $* install
%-install-dev:
- $(MAKE) -C $* install-dev
+ @echo "Installing $@"
+ $(Q)$(MAKE) $(MAKEOPTS) -C $* install-dev
%-install-qa:
- $(MAKE) -C $* install-qa
+ @echo "Installing $@"
+ $(Q)$(MAKE) $(MAKEOPTS) -C $* install-qa
distclean: clean
$(Q)rm -f $(DISTDIRT)
diff --git a/include/buildrules b/include/buildrules
index 1695e23..beb469b 100644
--- a/include/buildrules
+++ b/include/buildrules
@@ -101,7 +101,3 @@ ltdepend: $(CFILES) $(HFILES)
depend: $(CFILES) $(HFILES)
@echo " [DEP]"
$(Q)$(MAKEDEP) $(CFILES) > .dep
-
-
-# $(Q)$(MAKEDEP) $(CFILES) | $(SED) -e 's,^\([^:]*\)\.o,\1,' > .dep
-
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-02-05 11:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 9:22 make install in the brave new build system world Christoph Hellwig
2010-02-05 10:44 ` Dave Chinner
2010-02-05 11:17 ` Dave Chinner [this message]
2010-02-05 11:27 ` Christoph Hellwig
2010-02-05 11:28 ` Christoph Hellwig
2010-02-05 11:48 ` Dave Chinner
2010-02-08 10:29 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100205111741.GD11483@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox