From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: Christoph Hellwig <hch@infradead.org>,
Theodore Tso <tytso@mit.edu>, xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH V2] xfstests: fix up fs_perms test used by 126
Date: Tue, 9 Feb 2010 12:53:05 -0500 [thread overview]
Message-ID: <20100209175305.GA10833@infradead.org> (raw)
In-Reply-To: <4B71935E.7090907@sandeen.net>
On Tue, Feb 09, 2010 at 10:54:54AM -0600, Eric Sandeen wrote:
> Test 126 was failing intermittently for Ted & I; it seems that
> this is because we were passing an unterminated string to
> fopen for the mode; I'm not certain why this made it fail,
> but it's pretty clearly not a good thing to do, and fixing
> it fixes the test.
>
> Rather than passing around characters, do things string-wise,
> since that is what is ultimately used in fopen().
>
> Reported-by: Theodore Tso <tytso@mit.edu>
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-02-09 17:51 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-05 16:59 [PATCH] xfstests: fix up fs_perms test used by 126 Eric Sandeen
2010-02-08 19:40 ` Christoph Hellwig
2010-02-08 19:47 ` Eric Sandeen
2010-02-09 16:54 ` [PATCH V2] " Eric Sandeen
2010-02-09 17:53 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100209175305.GA10833@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=tytso@mit.edu \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox