* [PATCH] xfsprogs: fix some warnings
@ 2010-02-12 20:49 Alex Elder
2010-02-12 21:23 ` Christoph Hellwig
0 siblings, 1 reply; 3+ messages in thread
From: Alex Elder @ 2010-02-12 20:49 UTC (permalink / raw)
To: xfs
Fix a couple of build warnings.
Signed-off-by: Alex Elder <aelder@sgi.com>
---
ltp/fsx.c | 2 +-
src/loggen.c | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
Index: b/ltp/fsx.c
===================================================================
--- a/ltp/fsx.c
+++ b/ltp/fsx.c
@@ -1038,7 +1038,7 @@ __aio_rw(int rw, int fd, char *buf, unsi
fprintf(stderr, "bad io length: %lu instead of %u\n",
res, len);
else {
- fprintf(stderr, "errcode=%d\n", -res);
+ fprintf(stderr, "errcode=%ld\n", -res);
fprintf(stderr, "aio_rw: async io failed: %s\n",
strerror(-res));
ret = res;
Index: b/src/loggen.c
===================================================================
--- a/src/loggen.c
+++ b/src/loggen.c
@@ -240,6 +240,7 @@ loggen_empty(int count)
blfs.blf_type = XFS_LI_BUF;
blfs.blf_size = 2;
blfs.blf_flags = XFS_BLI_CANCEL;
+ blfs.blf_len = 0;
blfs.blf_blkno = 1;
blfs.blf_map_size = 1;
blfs.blf_data_map[0]= 0;
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] xfsprogs: fix some warnings
2010-02-12 20:49 [PATCH] xfsprogs: fix some warnings Alex Elder
@ 2010-02-12 21:23 ` Christoph Hellwig
2010-02-12 21:53 ` Alex Elder
0 siblings, 1 reply; 3+ messages in thread
From: Christoph Hellwig @ 2010-02-12 21:23 UTC (permalink / raw)
To: Alex Elder; +Cc: xfs
On Fri, Feb 12, 2010 at 02:49:45PM -0600, Alex Elder wrote:
> Fix a couple of build warnings.
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
>
> ---
> ltp/fsx.c | 2 +-
> src/loggen.c | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
Looks good, but it's actually for xfstests, not xfsdump as said in
the subject line.
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] xfsprogs: fix some warnings
2010-02-12 21:23 ` Christoph Hellwig
@ 2010-02-12 21:53 ` Alex Elder
0 siblings, 0 replies; 3+ messages in thread
From: Alex Elder @ 2010-02-12 21:53 UTC (permalink / raw)
To: Christoph Hellwig; +Cc: xfs
On Fri, 2010-02-12 at 16:23 -0500, Christoph Hellwig wrote:
> On Fri, Feb 12, 2010 at 02:49:45PM -0600, Alex Elder wrote:
> > Fix a couple of build warnings.
> >
> > Signed-off-by: Alex Elder <aelder@sgi.com>
> >
> > ---
> > ltp/fsx.c | 2 +-
> > src/loggen.c | 1 +
> > 2 files changed, 2 insertions(+), 1 deletion(-)
>
> Looks good, but it's actually for xfstests, not xfsdump as said in
> the subject line.
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
I will fix the subject line before I commit.
Thanks.
-Alex
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2010-02-12 21:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-12 20:49 [PATCH] xfsprogs: fix some warnings Alex Elder
2010-02-12 21:23 ` Christoph Hellwig
2010-02-12 21:53 ` Alex Elder
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox