public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] xfstests: use blkid raw mode
@ 2010-02-14 22:07 Christoph Hellwig
  2010-02-14 23:14 ` Dave Chinner
  0 siblings, 1 reply; 2+ messages in thread
From: Christoph Hellwig @ 2010-02-14 22:07 UTC (permalink / raw)
  To: xfs

blkid without options usually gets no probe results at all just after
creating a filesystem.  This problem is due to the cache that blkid
uses in it's default mode, and is unlikely to get fixed.  Use the -p
option to bypass the cache layer.

Signed-off-by: Christoph Hellwig <hch@lst.de>

Index: xfstests-dev/common
===================================================================
--- xfstests-dev.orig/common	2010-02-11 16:08:58.000000000 +0000
+++ xfstests-dev/common	2010-02-11 16:09:03.000000000 +0000
@@ -47,7 +47,7 @@ rm -f $tmp.list $tmp.tmp $tmp.sed
 # Autodetect fs type based on what's on $TEST_DEV
 if [ "$HOSTOS" == "Linux" ]
 then
-    export FSTYP=`blkid -s TYPE -o value $TEST_DEV`
+    export FSTYP=`blkid -p -s TYPE -o value $TEST_DEV`
 else
     export FSTYP=xfs
 fi

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH] xfstests: use blkid raw mode
  2010-02-14 22:07 [PATCH] xfstests: use blkid raw mode Christoph Hellwig
@ 2010-02-14 23:14 ` Dave Chinner
  0 siblings, 0 replies; 2+ messages in thread
From: Dave Chinner @ 2010-02-14 23:14 UTC (permalink / raw)
  To: Christoph Hellwig; +Cc: xfs

On Sun, Feb 14, 2010 at 05:07:53PM -0500, Christoph Hellwig wrote:
> blkid without options usually gets no probe results at all just after
> creating a filesystem.  This problem is due to the cache that blkid
> uses in it's default mode, and is unlikely to get fixed.  Use the -p
> option to bypass the cache layer.
> 
> Signed-off-by: Christoph Hellwig <hch@lst.de>

Make sense.

Reviewed-by: Dave Chinner <david@fromorbit.com>

-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2010-02-14 23:13 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2010-02-14 22:07 [PATCH] xfstests: use blkid raw mode Christoph Hellwig
2010-02-14 23:14 ` Dave Chinner

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox