From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 1/4] [PATCH 1/4] xfs: merge xfs_lrw.c into xfs_file.c
Date: Wed, 17 Feb 2010 14:36:26 +1100 [thread overview]
Message-ID: <20100217033626.GI28392@discord.disaster> (raw)
In-Reply-To: <20100215094603.932254045@bombadil.infradead.org>
On Mon, Feb 15, 2010 at 04:44:46AM -0500, Christoph Hellwig wrote:
> Currently the code to implement the file operations is split over two small
> files. Merge the content of xfs_lrw.c into xfs_file.c to have it in one
> place. Note that I haven't done various cleanups that are possible after
> this yet, they will follow in the next patch. Also the function
> xfs_dev_is_read_only which was in xfs_lrw.c before really doesn't fit in
> here at all and was moved to xfs_mount.c.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Looks good to me, so:
Reviewed-by: Dave Chinner <david@fromorbit.com>
As an additional step, perhaps it be a good idea to get rid of
xfs_lrw.h as well?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-02-17 3:35 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 9:44 [PATCH 0/4] implement optimized fdatasync Christoph Hellwig
2010-02-15 9:44 ` [PATCH 1/4] [PATCH 1/4] xfs: merge xfs_lrw.c into xfs_file.c Christoph Hellwig
2010-02-17 3:36 ` Dave Chinner [this message]
2010-02-17 8:14 ` Christoph Hellwig
2010-02-15 9:44 ` [PATCH 2/4] [PATCH 2/4] xfs: remove wrappers for read/write file operations Christoph Hellwig
2010-02-17 3:55 ` Dave Chinner
2010-02-17 8:31 ` Christoph Hellwig
[not found] ` <20100217211355.GR28392@discord.disaster>
2010-02-17 22:41 ` Dave Chinner
2010-02-25 20:33 ` Alex Elder
2010-02-15 9:44 ` [PATCH 3/4] [PATCH 3/4] xfs: remove wrapper for the fsync file operation Christoph Hellwig
2010-02-17 4:09 ` Dave Chinner
2010-02-17 8:33 ` Christoph Hellwig
2010-02-15 9:44 ` [PATCH 4/4] [PATCH 4/4] xfs: implement optimized fdatasync Christoph Hellwig
2010-02-17 4:17 ` Dave Chinner
2010-02-15 21:04 ` [PATCH 0/4] " Andi Kleen
2010-02-15 21:49 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217033626.GI28392@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox