From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: stop passing opaque handles to xfs_log.c routines
Date: Wed, 17 Feb 2010 15:42:27 +1100 [thread overview]
Message-ID: <20100217044227.GO28392@discord.disaster> (raw)
In-Reply-To: <20100215233454.GB28817@infradead.org>
On Mon, Feb 15, 2010 at 06:34:54PM -0500, Christoph Hellwig wrote:
> Currenly we pass opaque xfs_log_ticket_t handles instead of struct
> xlog_ticket pointers, and void pointers instead of struct xlog_in_core
> pointers to various log manager functions. Instead pass properly
> typed pointers after adding forward declarations for them to
> xfs_log.h, and adjust the touched function prototypes to the standard
> XFS style while at it.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
This is almost identical to a patch I've got in my stack ATM :)
Looks good.
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-02-17 4:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-15 23:34 [PATCH] xfs: stop passing opaque handles to xfs_log.c routines Christoph Hellwig
2010-02-17 4:42 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100217044227.GO28392@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox