From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o1H5BMdX207022 for ; Tue, 16 Feb 2010 23:11:22 -0600 Received: from mail.internode.on.net (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C95AF13B09AF for ; Tue, 16 Feb 2010 21:12:39 -0800 (PST) Received: from mail.internode.on.net (bld-mail19.adl2.internode.on.net [150.101.137.104]) by cuda.sgi.com with ESMTP id sBKr3JR0MErSYjaq for ; Tue, 16 Feb 2010 21:12:39 -0800 (PST) Date: Wed, 17 Feb 2010 16:12:36 +1100 From: Dave Chinner Subject: Re: [PATCH] xfs: factor common xfs_trans_bjoin code Message-ID: <20100217051236.GP28392@discord.disaster> References: <20100215233509.GC28817@infradead.org> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100215233509.GC28817@infradead.org> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Christoph Hellwig Cc: xfs@oss.sgi.com On Mon, Feb 15, 2010 at 06:35:09PM -0500, Christoph Hellwig wrote: > Most of xfs_trans_bjoin is duplicated in xfs_trans_get_buf, xfs_trans_getsb > and xfs_trans_read_buf. Add a new _xfs_trans_bjoin which can be called > by all four functions. > > Signed-off-by: Christoph Hellwig Looks good. Reviewed-by: Dave Chinner -- Dave Chinner david@fromorbit.com _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs