From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o1H8ClPM218734 for ; Wed, 17 Feb 2010 02:12:49 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id 5E77213B0FE5 for ; Wed, 17 Feb 2010 00:14:05 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id iPHWCdZJ9hUkGbjt for ; Wed, 17 Feb 2010 00:14:05 -0800 (PST) Date: Wed, 17 Feb 2010 03:14:03 -0500 From: Christoph Hellwig Subject: Re: [PATCH 1/4] [PATCH 1/4] xfs: merge xfs_lrw.c into xfs_file.c Message-ID: <20100217081403.GA19943@infradead.org> References: <20100215094445.528696829@bombadil.infradead.org> <20100215094603.932254045@bombadil.infradead.org> <20100217033626.GI28392@discord.disaster> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100217033626.GI28392@discord.disaster> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: Christoph Hellwig , xfs@oss.sgi.com On Wed, Feb 17, 2010 at 02:36:26PM +1100, Dave Chinner wrote: > On Mon, Feb 15, 2010 at 04:44:46AM -0500, Christoph Hellwig wrote: > > Currently the code to implement the file operations is split over two small > > files. Merge the content of xfs_lrw.c into xfs_file.c to have it in one > > place. Note that I haven't done various cleanups that are possible after > > this yet, they will follow in the next patch. Also the function > > xfs_dev_is_read_only which was in xfs_lrw.c before really doesn't fit in > > here at all and was moved to xfs_mount.c. > > > > Signed-off-by: Christoph Hellwig > > Looks good to me, so: > > Reviewed-by: Dave Chinner > > As an additional step, perhaps it be a good idea to get rid of > xfs_lrw.h as well? Yes, that's a good idea, I'll prepare a patch to do that. _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs