public inbox for linux-xfs@vger.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfstests: mount xfs with a context when selinux is on
Date: Thu, 18 Feb 2010 10:03:58 +1100	[thread overview]
Message-ID: <20100217230358.GX28392@discord.disaster> (raw)
In-Reply-To: <4B7C3F98.50303@sandeen.net>

On Wed, Feb 17, 2010 at 01:12:24PM -0600, Eric Sandeen wrote:
> When selinux is on, we get tons of new xattrs, which messes
> up all kinds of output.
> 
> The simplest way out of this, for now, seems to be to just mount
> with a global context instead and skip writing the extra xattrs.
> 
> I've been using this internally on Fedora and RHEL for a while now.
> 
> Signed-off-by: Eric Sandeen <sandeen@sandeen.net>

I know very little about selinux, so while the code changes look OK
I have no idea if the context change is All Goodness.

> --- a/common.rc
> +++ b/common.rc
> @@ -47,8 +47,16 @@ _ls_l()
>  
>  _mount_opts()
>  {
> +    # SELinux adds extra xattrs which can mess up our expected output.
> +    # So, mount with a context, and they won't be created
> +    # nfs_t is a "liberal" context so we can use it.
> +    if [ -x /usr/sbin/selinuxenabled ] && /usr/sbin/selinuxenabled; then
> +	SELINUX_MOUNT_OPTIONS="-o context=system_u:object_r:nfs_t:s0"
> +    fi
> +

i.e. is t_nfs a context specific to a RHEL/Fedora setup, or is it a
generic context that other distro's also define?

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2010-02-17 23:02 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2010-02-17 19:12 [PATCH] xfstests: mount xfs with a context when selinux is on Eric Sandeen
2010-02-17 23:03 ` Dave Chinner [this message]
2010-02-18 22:04   ` Eric Sandeen
2010-02-18 22:54     ` Eric Sandeen
2010-02-18 23:32       ` Dave Chinner

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20100217230358.GX28392@discord.disaster \
    --to=david@fromorbit.com \
    --cc=sandeen@sandeen.net \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox