From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/2] xfs: remove xfs_ipin/xfs_iunpin
Date: Fri, 19 Feb 2010 08:04:26 +1100 [thread overview]
Message-ID: <20100218210426.GA28392@discord.disaster> (raw)
In-Reply-To: <20100218124322.GB6016@infradead.org>
On Thu, Feb 18, 2010 at 07:43:22AM -0500, Christoph Hellwig wrote:
> On Thu, Feb 18, 2010 at 10:00:33AM +1100, Dave Chinner wrote:
> > > + ASSERT(atomic_read(&->i_pincount) > 0);
> >
> > I don't think that compiles. ;)
>
> It does in fact compile for non-debug builds, but here's an updated
Very true...
> version that also compiles in a debug build:
>
> ---
>
> From: Christoph Hellwig <hch@lst.de>
> Subject: [PATCH 2/2] xfs: remove xfs_ipin/xfs_iunpin
>
> Inodes are only pinned/unpinned via the inode item methods, and lots of
> code relies on that fact. So remove the separate xfs_ipin/xfs_iunpin
> helpers and merge them into their only callers. This also fixes up
> various duplicate and/or incorrect comments.
>
> Signed-off-by: Christoph Hellwig <hch@lst.de>
Reviewed-by: Dave Chinner <david@fromorbit.com>
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-02-18 21:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-02-17 19:44 [PATCH 2/2] xfs: remove xfs_ipin/xfs_iunpin Christoph Hellwig
[not found] ` <20100217230033.GW28392@discord.disaster>
2010-02-18 12:43 ` Christoph Hellwig
2010-02-18 21:04 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100218210426.GA28392@discord.disaster \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox