From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o240tp1X123833 for ; Wed, 3 Mar 2010 18:55:51 -0600 Date: Thu, 4 Mar 2010 11:57:09 +1100 From: Dave Chinner Subject: [PATCH] Re: linux-next: build warning after merge of the xfs tree Message-ID: <20100304005709.GE14317@discord.disaster> References: <20100304111930.86f7cc62.sfr@canb.auug.org.au> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <20100304111930.86f7cc62.sfr@canb.auug.org.au> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Stephen Rothwell Cc: aelder@sgi.com, xfs-masters@oss.sgi.com, linux-next@vger.kernel.org, linux-kernel@vger.kernel.org, xfs@oss.sgi.com On Thu, Mar 04, 2010 at 11:19:30AM +1100, Stephen Rothwell wrote: > Hi Dave, > > After merging the xfs tree, today's linux-next build (x86_64 allmodconfig) > produced this warning: > > fs/xfs/linux-2.6/xfs_aops.c: In function 'xfs_end_io': > fs/xfs/linux-2.6/xfs_aops.c:232: warning: 'error' may be used uninitialized in this function > > Introduced by commit 77d7a0c2eeb285c9069e15396703d0cb9690ac50 ("xfs: > Non-blocking inode locking in IO completion"). > > I can't tell if this is a false positive. If the first two "if" > statement bodies are skipped, then error is tested uninitialised. It is > possible that at least one of them has to be executed. Right, there is a warning being generated there - I thought I fixed that immediately after posting the first version of the patch. The second version: http://oss.sgi.com/archives/xfs/2010-02/msg00340.html definitely had it fixed. Alex, can you make sure you take the entire patch rather than cutting and pasting bits from one patch version to another? That way you don't miss small changes to the patch that might have been forgotten about.... Stephen, the patch below should fix the warning. Cheers, Dave. -- Dave Chinner david@fromorbit.com xfs: fix uninitialised variable warning in xfs_end_io Signed-off-by: Dave Chinner --- fs/xfs/linux-2.6/xfs_aops.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/fs/xfs/linux-2.6/xfs_aops.c b/fs/xfs/linux-2.6/xfs_aops.c index f41a2d8..8989c16 100644 --- a/fs/xfs/linux-2.6/xfs_aops.c +++ b/fs/xfs/linux-2.6/xfs_aops.c @@ -230,7 +230,7 @@ xfs_end_io( { xfs_ioend_t *ioend = container_of(work, xfs_ioend_t, io_work); struct xfs_inode *ip = XFS_I(ioend->io_inode); - int error; + int error = 0; /* * For unwritten extents we need to issue transactions to convert a _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs