From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/3] xfs: Increase the default size of the reserved blocks pool
Date: Sat, 6 Mar 2010 10:26:24 +1100 [thread overview]
Message-ID: <20100305232624.GA28189@discord.disaster> (raw)
In-Reply-To: <1267803953.2478.13.camel@doink>
On Fri, Mar 05, 2010 at 09:45:53AM -0600, Alex Elder wrote:
> On Thu, 2010-03-04 at 12:46 +1100, Dave Chinner wrote:
> > The current default size of the reserved blocks pool is easy to deplete
> > with certain workloads, in particular workloads that do lots of concurrent
> > delayed allocation extent conversions. If enough transactions are running
> > in parallel and the entire pool is consumed then subsequent calls to
> > xfs_trans_reserve() will fail with ENOSPC. Also add a rate limited
> > warning so we know if this starts happening again.
> >
> > This is an updated version of an old patch from Lachlan McIlroy.
>
> Looks good. The comment and code rearrangements are an
> improvement.
>
> I have also reviewed the other two patches in the series
> (including the updated patch 2) and they too look good.
>
> > Signed-off-by: Dave Chinner <david@fromorbit.com>
> So is it got to be fromorbit or redhat?
> (You used both in this series.)
What each individual patch says.
It depends on the history of the patch to what the sign-off I'll use
on it. This one I pulled from a patch series I had locally that
hadn't been touched for months (i.e. not new work). I simply updated
it for the recent resblks changes....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-03-05 23:25 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 1:46 [PATCH 0/3] xfs: delayed allocation @ ENOSPC fixes Dave Chinner
2010-03-04 1:46 ` [PATCH 1/3] xfs: check for more work before sleeping in xfssyncd Dave Chinner
2010-03-04 13:50 ` Christoph Hellwig
2010-03-04 22:56 ` Dave Chinner
2010-03-04 1:46 ` [PATCH 2/3] xfs: truncate delalloc extents when IO fails in writeback Dave Chinner
2010-03-04 14:28 ` Christoph Hellwig
2010-03-04 22:03 ` Dave Chinner
2010-03-05 2:00 ` [PATCH v2] " Dave Chinner
2010-03-05 9:21 ` Christoph Hellwig
2010-03-10 9:12 ` [PATCH 2/3] " Christoph Hellwig
2010-03-10 12:52 ` Dave Chinner
2010-03-10 18:18 ` Christoph Hellwig
2010-03-04 1:46 ` [PATCH 3/3] xfs: Increase the default size of the reserved blocks pool Dave Chinner
2010-03-05 15:45 ` Alex Elder
2010-03-05 23:26 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100305232624.GA28189@discord.disaster \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox