From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda2.sgi.com [192.48.176.25]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o26AoAb9079614 for ; Sat, 6 Mar 2010 04:50:11 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id C30E121FC3B for ; Sat, 6 Mar 2010 02:51:40 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id uS1r5nfbp9j7uXmw for ; Sat, 06 Mar 2010 02:51:40 -0800 (PST) Date: Sat, 6 Mar 2010 05:51:39 -0500 From: Christoph Hellwig Subject: Re: [PATCH 1/9] xfs: factor log item initialisation Message-ID: <20100306105139.GA30376@infradead.org> References: <1267840284-4652-1-git-send-email-david@fromorbit.com> <1267840284-4652-2-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1267840284-4652-2-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Sat, Mar 06, 2010 at 12:51:16PM +1100, Dave Chinner wrote: > From: Dave Chinner > > Each log item type does manual initialisation of the log item. > Delayed logging introduce?? new fields that need initialisation, so > factor all the open coded initialisation into a common function > first. > > Signed-off-by: Dave Chinner Looks good. While not really an obvious cleanup by itself I see where it comes in useful later. Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs