From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda3.sgi.com [192.48.176.15]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o26Aodr3079670 for ; Sat, 6 Mar 2010 04:50:39 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D7F3D1D1B0C7 for ; Sat, 6 Mar 2010 02:52:07 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id diQlHEKHicdAkxHt for ; Sat, 06 Mar 2010 02:52:07 -0800 (PST) Date: Sat, 6 Mar 2010 05:52:07 -0500 From: Christoph Hellwig Subject: Re: [PATCH 4/9] xfs: fix reservation release commit flag in xfs_bmap_add_attrfork() Message-ID: <20100306105207.GC30376@infradead.org> References: <1267840284-4652-1-git-send-email-david@fromorbit.com> <1267840284-4652-5-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1267840284-4652-5-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Sat, Mar 06, 2010 at 12:51:19PM +1100, Dave Chinner wrote: > From: Dave Chinner > > xfs_bmap_add_attrfork() passes XFS_TRANS_PERM_LOG_RES to xfs_trans_commit() > to indicate that the commit should release the permanent log reservation > as part of the commit. This is wrong - the correct flag is > XFS_TRANS_RELEASE_LOG_RES - and it is only by the chance that both these > flags have the value of 0x4 that the code is doing the right thing. > > Fix it by changing to use the correct flag. > > Signed-off-by: Dave Chinner Looks good, Reviewed-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs