From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from cuda.sgi.com (cuda1.sgi.com [192.48.157.11]) by oss.sgi.com (8.14.3/8.14.3/SuSE Linux 0.8) with ESMTP id o26AsO7f079948 for ; Sat, 6 Mar 2010 04:54:24 -0600 Received: from bombadil.infradead.org (localhost [127.0.0.1]) by cuda.sgi.com (Spam Firewall) with ESMTP id D404713FF1BF for ; Sat, 6 Mar 2010 02:55:53 -0800 (PST) Received: from bombadil.infradead.org (bombadil.infradead.org [18.85.46.34]) by cuda.sgi.com with ESMTP id 3WOcVZpaByit4HHe for ; Sat, 06 Mar 2010 02:55:53 -0800 (PST) Date: Sat, 6 Mar 2010 05:55:53 -0500 From: Christoph Hellwig Subject: Re: [PATCH 3/9] xfs: remove stale parameter from ->iop_unpin method Message-ID: <20100306105553.GD30376@infradead.org> References: <1267840284-4652-1-git-send-email-david@fromorbit.com> <1267840284-4652-4-git-send-email-david@fromorbit.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1267840284-4652-4-git-send-email-david@fromorbit.com> List-Id: XFS Filesystem from SGI List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: xfs-bounces@oss.sgi.com Errors-To: xfs-bounces@oss.sgi.com To: Dave Chinner Cc: xfs@oss.sgi.com On Sat, Mar 06, 2010 at 12:51:18PM +1100, Dave Chinner wrote: > The staleness of a object being unpinned can be directly derived > from the object itself - there is no need to extract it from the > object then pass it as a parameter into IOP_UNPIN(). Not quite as obvious as the description makes it sounds, as we're removing the XFS_LID_BUF_STALE flag, and the buf item which was the only place actually checking it is now switched to the XFS_BLI_STALE flag in the xfs_buf_log_item, but as these are set and cleared in exactly the same places it's fine and a great cleanups. Signed-off-by: Christoph Hellwig _______________________________________________ xfs mailing list xfs@oss.sgi.com http://oss.sgi.com/mailman/listinfo/xfs