From: Dave Chinner <david@fromorbit.com>
To: Jan Engelhardt <jengelh@medozas.de>
Cc: xfs@oss.sgi.com
Subject: Re: xfs: add fs name to kthreads
Date: Mon, 8 Mar 2010 12:28:24 +1100 [thread overview]
Message-ID: <20100308012824.GH28189@discord.disaster> (raw)
In-Reply-To: <alpine.LSU.2.01.1003062033100.16438@obet.zrqbmnf.qr>
On Sat, Mar 06, 2010 at 08:34:39PM +0100, Jan Engelhardt wrote:
> Signed-off-by: Jan Engelhardt <jengelh@medozas.de>
Looks ok, but a couple of things. First, it would be good if you
supplied a reason/justification for the patch so the commit message
will tell us why this change was made.
> Index: linux-2.6.33/fs/xfs/linux-2.6/xfs_buf.c
> ===================================================================
> --- linux-2.6.33.orig/fs/xfs/linux-2.6/xfs_buf.c
> +++ linux-2.6.33/fs/xfs/linux-2.6/xfs_buf.c
> @@ -1527,7 +1527,8 @@ xfs_mapping_buftarg(
>
> STATIC int
> xfs_alloc_delwrite_queue(
> - xfs_buftarg_t *btp)
> + xfs_buftarg_t *btp,
> + const char *fsname)
Please keep the same indent style as the rest of the functions. i.e
const char *fsname)
> @@ -1548,7 +1549,8 @@ out_error:
> xfs_buftarg_t *
> xfs_alloc_buftarg(
> struct block_device *bdev,
> - int external)
> + int external,
> + const char *fsname)
Same again.
> @@ -899,10 +899,11 @@ xfsaild(
>
> int
> xfsaild_start(
> - struct xfs_ail *ailp)
> + struct xfs_ail *ailp,
> + const char *fsname)
> {
> ailp->xa_target = 0;
> - ailp->xa_task = kthread_run(xfsaild, ailp, "xfsaild");
> + ailp->xa_task = kthread_run(xfsaild, ailp, "xfsaild/%s", fsname);
No need to pass the name into this function. It can be retrieved
from ailp->xa_mount->m_fsname.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-03-08 1:26 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-06 19:34 xfs: add fs name to kthreads Jan Engelhardt
2010-03-08 1:28 ` Dave Chinner [this message]
2010-03-18 14:13 ` Jan Engelhardt
2010-03-24 21:53 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100308012824.GH28189@discord.disaster \
--to=david@fromorbit.com \
--cc=jengelh@medozas.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox