From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: Christoph Hellwig <hch@infradead.org>,
Eric Sandeen <sandeen@sandeen.net>,
Michael Weissenbacher <mw@dermichi.com>,
xfs@oss.sgi.com
Subject: Re: XFS hang during xfs_fsr run
Date: Fri, 12 Mar 2010 09:27:37 -0500 [thread overview]
Message-ID: <20100312142737.GA16244@infradead.org> (raw)
In-Reply-To: <20100312115645.GD4732@dastard>
On Fri, Mar 12, 2010 at 10:56:45PM +1100, Dave Chinner wrote:
> ->page_mkwrite executes without the inode iolock held, so we can't
> lock it out from creating new delalloc pages by holding the iolock
> like the bmap code does.
>
> I don't think we're allowed to take the iolock in ->page_mkwrite, so
> effectively that leaves us with the situation where we can't do an
> atomic flush and map in the bmap code.
>
> Christoph, I guess that means we need to make the bmap code
> handle/ignore delalloc extents rather than assume they never occur
> after the flush. What do you think?
The current swapext code is supposed to skip any file that is mapped
into userspace via mmap. So if you get a file that is actually mmaped
something is wrong with that check. From a quick look the only problem
I see is that we don't take the iolock in ->mmap so we could add a new
mapping after the check, but I'd be surprise if that is what Michael
is seeing.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-03-12 14:26 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-04 10:10 XFS hang during xfs_fsr run Michael Weissenbacher
2010-03-04 11:20 ` Dave Chinner
2010-03-04 12:08 ` Michael Weissenbacher
2010-03-04 13:15 ` Dave Chinner
2010-03-04 13:46 ` Christoph Hellwig
2010-03-04 14:20 ` Michael Weissenbacher
2010-03-04 14:30 ` Christoph Hellwig
2010-03-04 17:14 ` Michael Weissenbacher
2010-03-04 22:26 ` Dave Chinner
2010-03-05 9:04 ` Michael Weissenbacher
2010-03-06 21:20 ` Michael Weissenbacher
2010-03-08 0:06 ` Dave Chinner
2010-03-08 12:17 ` Michael Weissenbacher
2010-03-08 18:09 ` Eric Sandeen
2010-03-09 9:14 ` Michael Weissenbacher
2010-03-09 11:38 ` Dave Chinner
2010-03-09 12:09 ` Michael Weissenbacher
2010-03-10 8:46 ` Michael Weissenbacher
2010-03-11 23:39 ` Dave Chinner
2010-03-12 9:45 ` Michael Weissenbacher
2010-03-12 10:00 ` Christoph Hellwig
2010-03-12 10:36 ` Michael Weissenbacher
2010-03-12 11:56 ` Dave Chinner
2010-03-12 14:27 ` Christoph Hellwig [this message]
2010-03-13 0:25 ` Dave Chinner
2010-04-16 8:10 ` Michael Monnerie
2010-04-16 10:50 ` Michael Weissenbacher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100312142737.GA16244@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=mw@dermichi.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox