From: Christoph Hellwig <hch@infradead.org>
To: Dave Chinner <david@fromorbit.com>
Cc: xfs@oss.sgi.com
Subject: Re: [RFC] Delayed logging
Date: Mon, 15 Mar 2010 12:33:24 -0400 [thread overview]
Message-ID: <20100315163324.GA26379@infradead.org> (raw)
In-Reply-To: <20100315160154.GA10406@infradead.org>
On Mon, Mar 15, 2010 at 12:01:54PM -0400, Christoph Hellwig wrote:
> Running the series on my KVM testbox trips out this assert in
> xfstests 013, which suggests we might be calling iput one too
> much somewhere (e.g. IOP_UNLOCK)):
>
> [ 132.174780] Assertion failed: atomic_read(&VFS_I(dp)->i_count) > 0, file: fs/xfs/xfs_vnodeops.c, line: 1430
Turns out this was due to the fsync clustering patch, which adds inodes
to a transaction without first grabbing a reference to them.
Unofrtunately grabbing the reference is not a easy as it sounds, as
inodes in the cluster might be on the unused list or even not have
valid VFS state anymore, so we can't simply call IHOLD here. I've
reverted the patch in my local tree for now.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-03-15 16:31 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-15 4:30 [RFC] Delayed logging Dave Chinner
2010-03-15 16:01 ` Christoph Hellwig
2010-03-15 16:33 ` Christoph Hellwig [this message]
2010-03-16 1:06 ` Dave Chinner
2010-03-15 16:08 ` Christoph Hellwig
2010-03-16 1:14 ` Dave Chinner
2010-03-15 16:38 ` Christoph Hellwig
2010-03-16 1:15 ` Dave Chinner
2010-03-15 18:08 ` Christoph Hellwig
2010-03-16 1:20 ` Dave Chinner
2010-03-31 13:26 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100315163324.GA26379@infradead.org \
--to=hch@infradead.org \
--cc=david@fromorbit.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox