From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 2/7] xfs: fix min bufsize bugs in two places
Date: Sat, 20 Mar 2010 12:42:49 -0400 [thread overview]
Message-ID: <20100320164249.GB31444@infradead.org> (raw)
In-Reply-To: <201003182253.o2IMrp54001850@stout.americas.sgi.com>
> +/* Number of basic blocks in a log sector */
> +#define xlog_sectbb(log) (1 << (log)->l_sectbb_log)
Looking at all uses of (log)->l_sectbb_log I wonder if we should
bother storing this in the log structure in this form, or rather
as the multipler of the basic block size, ala l_sectsize. All the
if (log->l_sectbb_log) {
checks would just become
if (log->l_sectsize > 1) {
and the xlog_find_verify_cycle/xlog_write_log_records checks
would also be a natural
if (bufblks < log->l_sectsize)
The comments added are defintively useful, btw.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-03-20 16:41 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 22:53 [PATCH 2/7] xfs: fix min bufsize bugs in two places Alex Elder
2010-03-20 16:42 ` Christoph Hellwig [this message]
2010-03-25 14:23 ` Alex Elder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320164249.GB31444@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox