From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/7] xfs: kill XLOG_SECTOR_ROUND*()
Date: Sat, 20 Mar 2010 12:48:04 -0400 [thread overview]
Message-ID: <20100320164804.GD31444@infradead.org> (raw)
In-Reply-To: <201003182254.o2IMs1jH001874@stout.americas.sgi.com>
> @@ -82,8 +77,8 @@ xlog_get_bp(
>
> if (log->l_sectbb_log) {
> if (nbblks > 1)
> - nbblks += XLOG_SECTOR_ROUNDUP_BBCOUNT(log, 1);
> - nbblks = XLOG_SECTOR_ROUNDUP_BBCOUNT(log, nbblks);
> + nbblks += xlog_sectbb(log);
> + nbblks = round_up(nbblks, xlog_sectbb(log));
This arithmetics would benefit greatly from a comment why we're
adding one log block to it and then round it up.
Anyway, patch looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-03-20 16:46 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 22:54 [PATCH 4/7] xfs: kill XLOG_SECTOR_ROUND*() Alex Elder
2010-03-20 16:48 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320164804.GD31444@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox