From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 6/7] xfs: nothing special about 1-block log sector
Date: Sat, 20 Mar 2010 12:50:11 -0400 [thread overview]
Message-ID: <20100320165011.GE31444@infradead.org> (raw)
In-Reply-To: <201003182254.o2IMsBck001887@stout.americas.sgi.com>
> + /*
> + * We do log I/O in units of log sectors (a power-of-2
> + * multiple of the basic block size), so we round up the
> + * requested size to acommodate the basic blocks required
> + * for complete log sectors.
> + *
> + * In addition, the buffer may be used for a non-sector-
> + * aligned block offset, in which case an I/O of the
> + * requested size could extend beyond the end of the
> + * buffer. If the requested size is only 1 basic block it
> + * will never straddle a sector boundary, so this won't be
> + * an issue. Nor will this be a problem if the log I/O is
> + * done in basic blocks (sector size 1). But otherwise we
> + * extend the buffer by one extra log sector to ensure
> + * there's space to accomodate this possiblility.
> + */
Ah, you're adding the comment that I asked a few patches ago here,
great!
The patch looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-03-20 16:48 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-18 22:54 [PATCH 6/7] xfs: nothing special about 1-block log sector Alex Elder
2010-03-20 16:50 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100320165011.GE31444@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox