From: Christoph Hellwig <hch@infradead.org>
To: Lasse Kliemann <lasse-private-2010@mail.plastictree.net>
Cc: xfs@oss.sgi.com
Subject: Re: builddefs.in
Date: Mon, 22 Mar 2010 11:33:25 -0400 [thread overview]
Message-ID: <20100322153325.GA29823@infradead.org> (raw)
In-Reply-To: <20100321141349.GE1827@lasse.mail.plastictre.net>
On Sun, Mar 21, 2010 at 03:13:50PM +0100, Lasse Kliemann wrote:
> Using 3.1.1.
>
> When configured with a '--prefix', the build fails:
>
> [...]
> [CC] linux.lo
> [LD] libxfs.la
> libtool: link: only absolute run-paths are allowed
> gmake[2]: *** [libxfs.la] Error 1
> gmake[1]: *** [libxfs] Error 2
> make: *** [default] Error 2
>
> Calling 'make' in 'libxfs' reveals that '-rpath' option is used
> with no argument. The attached patch remedies this. Indeed, with
> this patch the correct argument is given to '-rpath', at least in
> 'libxfs' subdirectory.
>
> It also remedies a similar problem when installing executables
> into '.../sbin' directory.
> diff --git a/include/builddefs.in b/include/builddefs.in
> index cc75b5d..801b09e 100644
> --- a/include/builddefs.in
> +++ b/include/builddefs.in
> @@ -52,8 +52,8 @@ datarootdir = @datarootdir@
> top_builddir = @top_builddir@
>
> PKG_SBIN_DIR = @sbindir@
> -PKG_ROOT_SBIN_DIR = @root_sbindir@
> -PKG_ROOT_LIB_DIR= @root_libdir@@libdirsuffix@
> +PKG_ROOT_SBIN_DIR = @sbindir@
> +PKG_ROOT_LIB_DIR= @libdir@@libdirsuffix@
This is against the intent of the whole ROOT_LIB/SBIN_DIR
mechnism as it makes them equivalent to the normal ones.
It seems we have some problem generatin the correct @root_sbindir@ /
@root_libdir@ paths in the autoconf macros for your use case, I'll
look into that once I get a bit of time.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-03-22 15:31 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-21 14:13 builddefs.in Lasse Kliemann
2010-03-22 15:33 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100322153325.GA29823@infradead.org \
--to=hch@infradead.org \
--cc=lasse-private-2010@mail.plastictree.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox