From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Always update the log tail on disk in sync
Date: Mon, 29 Mar 2010 14:23:40 +1100 [thread overview]
Message-ID: <20100329032340.GP3335@dastard> (raw)
In-Reply-To: <20100328093541.GA11654@infradead.org>
On Sun, Mar 28, 2010 at 05:35:41AM -0400, Christoph Hellwig wrote:
>
> Looks good.
>
>
> Reviewed-by: Christoph Hellwig <hch@lst.de>
>
> > + switch (log->l_covered_state) {
> > + case XLOG_STATE_COVER_NEED:
> > + case XLOG_STATE_COVER_NEED2:
> > + if (!xfs_trans_ail_tail(log->l_ailp) &&
> > + xlog_iclogs_empty(log)) {
> > + if (log->l_covered_state == XLOG_STATE_COVER_NEED)
> > + log->l_covered_state = XLOG_STATE_COVER_DONE;
> > + else {
> > + ASSERT(log->l_covered_state == XLOG_STATE_COVER_NEED2);
>
> Moving this assert into the switch introduces an overly long line.
> But it's rather pintless anyway, so we can just drop it.
>
> Together with reordering the switch statement for slightly better
> readability we might get something like the version below:
Yeah, that looks better. I'll run it through cycle and repost when
done.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-03-29 3:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-03-25 5:07 [PATCH] xfs: Always update the log tail on disk in sync Dave Chinner
2010-03-28 9:35 ` Christoph Hellwig
2010-03-29 3:23 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100329032340.GP3335@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox