From: Dave Chinner <david@fromorbit.com>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs mailing list <xfs@oss.sgi.com>
Subject: Re: [PATCH, RFC] xfstests: random fallocate calls in fsx
Date: Wed, 31 Mar 2010 16:41:56 +1100 [thread overview]
Message-ID: <20100331054156.GV3335@dastard> (raw)
In-Reply-To: <4BB2D65D.5000402@sandeen.net>
On Tue, Mar 30, 2010 at 11:58:05PM -0500, Eric Sandeen wrote:
> Eric Sandeen wrote:
> > Seems to work for me. Any comments/suggestions?
> >
> > I can probably make it fall back to the xfs ioctl if fallocate
> > isn't supported, if strongly desired.
>
> Anybody feel like reviewing this? Seems like having fallocate in the mix
> would be good.
Looks like all of the autoconf magic went in with the fiemap-tester
changes, so a rebase is definitely needed... :/
Otherwise the changes seem sane - I can't find anything obviously
wrong reading over them. I say clean it up, check it doesn't
obviously break and check it in...
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-03-31 5:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-13 21:56 [PATCH, RFC] xfstests: random fallocate calls in fsx Eric Sandeen
2009-06-03 20:46 ` Eric Sandeen
2009-06-03 23:19 ` Josef 'Jeff' Sipek
2009-07-27 2:46 ` Eric Sandeen
2010-03-31 4:58 ` Eric Sandeen
2010-03-31 5:41 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100331054156.GV3335@dastard \
--to=david@fromorbit.com \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox