From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 4/8] xfs: add log item recovery tracing
Date: Tue, 6 Apr 2010 09:40:16 +1000 [thread overview]
Message-ID: <20100405234016.GB11036@dastard> (raw)
In-Reply-To: <20100403093638.GE20166@infradead.org>
On Sat, Apr 03, 2010 at 05:36:38AM -0400, Christoph Hellwig wrote:
> On Thu, Apr 01, 2010 at 11:41:27PM +1100, Dave Chinner wrote:
> > From: Dave Chinner <dchinner@redhat.com>
> >
> > Currently there is no tracing in log recovery, so it is difficult to
> > determine what is going on when something goes wrong.
> >
> > Add tracing for log item recovery to provide visibility into the log
> > recovery process. The tracing added shows regions being extracted
> > from the log transactions and added to the transaction hash forming
> > recovery items, followed by the reordering, cancelling and finally
> > recovery of the items.
> >
> > Signed-off-by: Dave Chinner <dchinner@redhat.com>
> > ---
> > fs/xfs/linux-2.6/xfs_trace.c | 3 +
> > fs/xfs/linux-2.6/xfs_trace.h | 147 ++++++++++++++++++++++++++++++++++++++++++
> > fs/xfs/xfs_buf_item.h | 2 +-
> > fs/xfs/xfs_log_recover.c | 44 ++++++++++--
> > 4 files changed, 187 insertions(+), 9 deletions(-)
> >
>
> > +#define XFS_LOG_ITEM_TYPE \
> > + { 0x1236, "XFS_LI_EFI" }, \
> > + { 0x1237, "XFS_LI_EFD" }, \
> > + { 0x1238, "XFS_LI_IUNLINK" }, \
> > + { 0x123b, "XFS_LI_INODE" }, \
> > + { 0x123c, "XFS_LI_BUF" }, \
> > + { 0x123d, "XFS_LI_DQUOT" }, \
> > + { 0x123e, "XFS_LI_QUOTAOFF" }
>
> For the other trace events I kept these close to the defintion
> of these flags.
np, I'll move it.
> Is there a good reason you use the numerical
> and not hte symbolic names on the left side?
Brain fart. I'll fix it up.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-04-05 23:38 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-01 12:41 [PATCH 0/8] xfs: bug fixes, cleanups and tracing Dave Chinner
2010-04-01 12:41 ` [PATCH 2/8] xfs: don't warn on EAGAIN in inode reclaim Dave Chinner
2010-04-03 9:25 ` Christoph Hellwig
2010-04-01 12:41 ` [PATCH 3/8] xfs: make the log ticket transaction id random Dave Chinner
2010-04-03 9:31 ` Christoph Hellwig
2010-04-05 23:39 ` Dave Chinner
2010-04-13 18:12 ` Christoph Hellwig
2010-04-01 12:41 ` [PATCH 4/8] xfs: add log item recovery tracing Dave Chinner
2010-04-03 9:36 ` Christoph Hellwig
2010-04-05 23:40 ` Dave Chinner [this message]
2010-04-01 12:41 ` [PATCH 5/8] xfs: convert the per-mount dquot list to use list heads Dave Chinner
2010-04-03 9:59 ` Christoph Hellwig
2010-04-01 12:41 ` [PATCH 6/8] xfs: remove duplicate code from dquot reclaim Dave Chinner
2010-04-03 10:00 ` Christoph Hellwig
2010-04-01 12:41 ` [PATCH 7/8] xfs: convert the dquot hash list to use list heads Dave Chinner
2010-04-03 10:00 ` Christoph Hellwig
2010-04-01 12:41 ` [PATCH 8/8] xfs: convert the dquot free " Dave Chinner
2010-04-03 10:00 ` Christoph Hellwig
2010-04-03 10:02 ` [PATCH 9/8] xfs: remove xfs_dqmarker Christoph Hellwig
2010-04-05 23:20 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100405234016.GB11036@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox