From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCHv2 9/10] xfs: a few more minor xfs_log_recover.c cleanups
Date: Mon, 12 Apr 2010 17:11:31 +1000 [thread overview]
Message-ID: <20100412071131.GK2493@dastard> (raw)
In-Reply-To: <1270852266.7840.159.camel@doink>
On Fri, Apr 09, 2010 at 05:31:06PM -0500, Alex Elder wrote:
> Minor things that didn't seem to warrant their own individual
> patches:
> - In xlog_bread_noalign(), reorder assertions so the buffer pointer
> is known to be non-null before attempting to dereference it.
That's OK, but if you are debugging then it'll be obvious what
happend by it being a null ptr dereference rather than an assert
failure. Hence if anything I'd just kill the ASSERT(bp)....
> - Add a more descriptive header comment for xlog_find_verify_cycle().
It just describes what the code does - I don't think it make the
code any clearer and makes it more likely that if we ever change the
code the comment will then be wrong...
> - Make a few additions to the comments in xlog_find_head(). Also
> rearrange some expressions in a few spots to produce the same
> result, but in a way that seems more clear what's being computed.
I'd say this is probably the only bits of the patch that add value.
Can you split this one out by itself?
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-04-13 1:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 22:31 [PATCHv2 9/10] xfs: a few more minor xfs_log_recover.c cleanups Alex Elder
2010-04-12 7:11 ` Dave Chinner [this message]
2010-04-14 21:19 ` Alex Elder
2010-04-15 0:09 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100412071131.GK2493@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox