From: Dave Chinner <david@fromorbit.com>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCHv2 9/10] xfs: a few more minor xfs_log_recover.c cleanups
Date: Thu, 15 Apr 2010 10:09:04 +1000 [thread overview]
Message-ID: <20100415000904.GN2493@dastard> (raw)
In-Reply-To: <1271279952.3559.81.camel@doink>
On Wed, Apr 14, 2010 at 04:19:12PM -0500, Alex Elder wrote:
> On Mon, 2010-04-12 at 17:11 +1000, Dave Chinner wrote:
> > On Fri, Apr 09, 2010 at 05:31:06PM -0500, Alex Elder wrote:
> > > - Add a more descriptive header comment for xlog_find_verify_cycle().
> >
> > It just describes what the code does - I don't think it make the
> > code any clearer and makes it more likely that if we ever change the
> > code the comment will then be wrong...
>
> I still think the existing comments are confusing. What do you
> think of this instead:
>
> /*
> * Check that the range of blocks does not contain stop_on_cycle_no.
> * Fill in *new_blk with the block offset where such block is found,
> * or with -1 (an invalid block number) if there is no such block in
> * the range. The scan needs to occur from front to back and the
> * pointer into the region must be updated since a later routine will
> * need to perform another test.
> */
Yup, that's much better ;)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-04-15 0:07 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 22:31 [PATCHv2 9/10] xfs: a few more minor xfs_log_recover.c cleanups Alex Elder
2010-04-12 7:11 ` Dave Chinner
2010-04-14 21:19 ` Alex Elder
2010-04-15 0:09 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100415000904.GN2493@dastard \
--to=david@fromorbit.com \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox