From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH 3/5] xfs: minor odds and ends in xfs_log_recover.c
Date: Fri, 16 Apr 2010 13:09:00 -0400 [thread overview]
Message-ID: <20100416170900.GC2729@infradead.org> (raw)
In-Reply-To: <1271355454.2680.92.camel@doink>
On Thu, Apr 15, 2010 at 01:17:34PM -0500, Alex Elder wrote:
> Odds and ends in "xfs_log_recover.c". This patch just contains some
> minor things that didn't seem to warrant their own individual
> patches:
> - In xlog_bread_noalign(), drop an assertion that a pointer is
> non-null (the crash will tell us it was a bad pointer).
> - Add a more descriptive header comment for xlog_find_verify_cycle().
> - Make a few additions to the comments in xlog_find_head(). Also
> rearrange some expressions in a few spots to produce the same
> result, but in a way that seems more clear what's being computed.
>
> (Updated in response to Dave's review comments. Note I did not
> split this patch like I said I would.)
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Looks good,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-04-16 17:07 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 18:17 [PATCH 3/5] xfs: minor odds and ends in xfs_log_recover.c Alex Elder
2010-04-16 17:09 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416170900.GC2729@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox