From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: XFS Mailing List <xfs@oss.sgi.com>
Subject: Re: [PATCH 4/5] xfs: record log sector size rather than log2(that)
Date: Fri, 16 Apr 2010 13:10:59 -0400 [thread overview]
Message-ID: <20100416171059.GD2729@infradead.org> (raw)
In-Reply-To: <1271355457.2680.93.camel@doink>
On Thu, Apr 15, 2010 at 01:17:37PM -0500, Alex Elder wrote:
> Change struct log so it keeps track of the size (in basic blocks)
> of a log sector in l_sectsize rather than the log-base-2 of that
> value (previously, l_sectbb_log). Rename a variable holding the
> sector size to more closely match the field it comes from.
>
> (Updated so that a variable used in computing and verifying a log's
> sector size is named simply "size". Also dropped some superfluous
> parentheses and renamed another local variable.)
>
> Signed-off-by: Alex Elder <aelder@sgi.com>
Looks correct, but I don't think the choice of "size" for a log2
is particularly intuitive.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-04-16 17:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-15 18:17 [PATCH 4/5] xfs: record log sector size rather than log2(that) Alex Elder
2010-04-16 17:10 ` Christoph Hellwig [this message]
2010-04-16 19:27 ` Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100416171059.GD2729@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox