From: Christoph Hellwig <hch@infradead.org>
To: Alex Elder <aelder@sgi.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCHv2 4/5] xfs: record log sector size rather than log2(that)
Date: Sun, 18 Apr 2010 13:18:05 -0400 [thread overview]
Message-ID: <20100418171805.GA28944@infradead.org> (raw)
In-Reply-To: <201004162053.o3GKrrgr025189@stout.americas.sgi.com>
On Fri, Apr 16, 2010 at 03:53:53PM -0500, Alex Elder wrote:
> Change struct log so it keeps track of the size (in basic blocks) of
> a log sector in l_sectBBsize rather than the log-base-2 of that
> value (previously, l_sectbb_log). The name was chosen for
> consistency with the other fields in the structure that represent
> a number of basic blocks.
>
> (Updated so that a variable used in computing and verifying a log's
> sector size is named "log2_size". Also added the "BB" to the
> structure field name, based on feedback from Eric Sandeen. Also
> dropped some superfluous parentheses.)
Looks good. Eventually we should replace all the "BB" with "bb" in
the log code, but for now this is a good enough.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-04-18 17:16 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-16 20:53 [PATCHv2 4/5] xfs: record log sector size rather than log2(that) Alex Elder
2010-04-16 21:17 ` Eric Sandeen
2010-04-18 17:18 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100418171805.GA28944@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox