From: Dave Chinner <david@fromorbit.com>
To: Wenming Zhang <wezhang@redhat.com>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: fix compile issue with gdbm and --enable-lib64 warnnings
Date: Tue, 20 Apr 2010 14:57:48 +1000 [thread overview]
Message-ID: <20100420045748.GC15130@dastard> (raw)
In-Reply-To: <1270784882-8130-1-git-send-email-wezhang@redhat.com>
On Fri, Apr 09, 2010 at 11:48:02AM +0800, Wenming Zhang wrote:
> fix couldn't be compiled with gdbm lib issue
> and clear warnings while configure with --enable-lib64
>
> Signed-off-by: Wenming Zhang <wezhang@redhat.com>
> ---
> configure.in | 7 +++++++
> 1 files changed, 7 insertions(+), 0 deletions(-)
>
> diff --git a/configure.in b/configure.in
> index 45b7fd1..92e2711 100644
> --- a/configure.in
> +++ b/configure.in
> @@ -10,6 +10,7 @@ AC_HEADER_STDC
> errno.h \
> malloc.h \
> uuid.h \
> + gdbm.h \
> uuid/uuid.h \
> sys/uuid.h \
> sys/file.h \
I'm not sure why this is needed - we don't directly include gdbm.h.
We check for gdbm/ndbm.h (or gdbm-ndbm.h on debian in a a patch
I have), the presence of which implies that gdbm.h exists on the
system.
Even if it is necessary to check for this, the check needs to go
into the GDBM package checks (m4/package_gdbmdev.m4) to
enable/disable the have_db variable so that it simply isn't used if
it is not present.
> @@ -44,6 +45,12 @@ in
> ;;
> *)
> AC_MULTILIB($enable_lib64)
> + AC_ARG_ENABLE([lib64], [AS_HELP_STRING([--enable-lib64],
> + [enable lib64 support (default is no)])],
> + [enable_lib64=$withval],
> + [enable_lib64=no]
> + )
> +
I don't think this is right - yes, it will suppress the warning,
but I don't think it works correctly. The argument needs to be enabled
and evaluated before it is used, and IIRC the AC_ARG_ENABLE result
is put into $enableval not $withval.
So shouldn't it be something like this (untested):
AC_ARG_ENABLE(lib64,
AS_HELP_STRING([--enable-lib64],
[enable lib64 support (default=no)]
enable_lib64=$enableval,
enable_lib64=no)
AC_SUBST(enable_lib64)
AC_MULTILIB($enable_lib64)
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-04-20 4:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-09 3:48 [PATCH] xfstests: fix compile issue with gdbm and --enable-lib64 warnnings Wenming Zhang
2010-04-20 4:57 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100420045748.GC15130@dastard \
--to=david@fromorbit.com \
--cc=wezhang@redhat.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox