From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [PATCH] xfs: Improve scalability of busy extent tracking
Date: Fri, 23 Apr 2010 13:25:33 +1000 [thread overview]
Message-ID: <20100423032533.GE10390@dastard> (raw)
In-Reply-To: <20100422171035.GA29007@infradead.org>
On Thu, Apr 22, 2010 at 01:10:35PM -0400, Christoph Hellwig wrote:
> On Thu, Apr 22, 2010 at 07:07:58AM -0400, Christoph Hellwig wrote:
> > Oh, and while I'm at it:
> >
> > I'd move the list_del_init(&busyp->list); from xfs_trans_free_busy into
> > xfs_alloc_clear_busy, we also do the list insertation inside
> > xfs_alloc_busy_insert, so that makes it symmetic.
>
> Or just merge the loop calling xfs_alloc_clear_busy directly in
> xfs_trans_free, ala:
Yeah, that looks like a sane thing to do. I'll update it this way.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-04-23 3:23 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-21 5:47 [PATCH] xfs: Improve scalability of busy extent tracking Dave Chinner
2010-04-22 11:01 ` Christoph Hellwig
2010-04-22 16:16 ` Dave Chinner
2010-04-22 17:08 ` Christoph Hellwig
2010-04-23 3:24 ` Dave Chinner
2010-04-22 11:07 ` Christoph Hellwig
2010-04-22 17:10 ` Christoph Hellwig
2010-04-23 3:25 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100423032533.GE10390@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox