From: Christoph Hellwig <hch@infradead.org>
To: Tao Ma <tao.ma@oracle.com>
Cc: Eric Sandeen <sandeen@redhat.com>, Alex Elder <aelder@sgi.com>,
Christoph Hellwig <hch@lst.de>,
linux-kernel@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH v2] XFS: Let the broken fiemap work in query mode.
Date: Wed, 28 Apr 2010 07:33:59 -0400 [thread overview]
Message-ID: <20100428113359.GB27769@infradead.org> (raw)
In-Reply-To: <1272423625-20142-1-git-send-email-tao.ma@oracle.com>
On Wed, Apr 28, 2010 at 11:00:25AM +0800, Tao Ma wrote:
> - bm.bmv_count = fieinfo->fi_extents_max + 1;
> + bm.bmv_count = !fieinfo->fi_extents_max ? MAXEXTNUM :
> + fieinfo->fi_extents_max + 1;
> + bm.bmv_count = MIN(bm.bmv_count,
> + (__s32)(PAGE_SIZE * 16 / sizeof(struct getbmapx)));
I would use min_t here instead of the case, but otherwise the patch
looks good to me,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-04-28 11:31 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-27 6:17 [PATCH] XFS: Let the broken fiemap work in query mode Tao Ma
2010-04-28 1:50 ` Dave Chinner
2010-04-28 2:00 ` Tao Ma
2010-04-28 2:30 ` Dave Chinner
2010-04-28 3:00 ` [PATCH v2] " Tao Ma
2010-04-28 11:33 ` Christoph Hellwig [this message]
2010-04-28 14:39 ` [PATCH v3] " Tao Ma
2010-04-28 6:50 ` [PATCH] xfstests: Add query fiemap count test Tao Ma
2010-04-29 5:35 ` Dave Chinner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100428113359.GB27769@infradead.org \
--to=hch@infradead.org \
--cc=aelder@sgi.com \
--cc=hch@lst.de \
--cc=linux-kernel@vger.kernel.org \
--cc=sandeen@redhat.com \
--cc=tao.ma@oracle.com \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox