From: Christoph Hellwig <hch@infradead.org>
To: xfs@oss.sgi.com
Subject: [PATCH] xfstests: fix fiemap-tester when build without fallocate
Date: Thu, 29 Apr 2010 06:39:16 -0400 [thread overview]
Message-ID: <20100429103916.GA10535@infradead.org> (raw)
Make sure at least the tests passing -p0 like xfstests 225 can work when
built without fallocate support.
Signed-off-by: Christoph Hellwig <hch@lst.de>
Index: xfstests-dev/src/fiemap-tester.c
===================================================================
--- xfstests-dev.orig/src/fiemap-tester.c 2010-04-29 10:32:52.000000000 +0000
+++ xfstests-dev/src/fiemap-tester.c 2010-04-29 10:35:11.000000000 +0000
@@ -37,14 +37,10 @@ static void
usage(void)
{
printf("Usage: fiemap-tester [-m map] [-r number of runs] [-s seed] [-q]");
-#ifdef HAVE_FALLOCATE
printf("[-p preallocate (1/0)] ");
-#endif
printf("filename\n");
printf(" -m map : generate a file with the map given and test\n");
-#ifdef HAVE_FALLOCATE
printf(" -p 0/1 : turn block preallocation on or off\n");
-#endif
printf(" -r count : number of runs to execute (default infinity)\n");
printf(" -s seed : seed for random map generator (default 1)\n");
printf(" -q : be quiet about non-errors\n");
@@ -513,9 +509,10 @@ main(int argc, char **argv)
case 'p':
prealloc = atoi(optarg);;
#ifndef HAVE_FALLOCATE
- if (prealloc)
+ if (prealloc) {
printf("Not built with preallocation support\n");
- usage();
+ usage();
+ }
#endif
break;
case 'q':
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next reply other threads:[~2010-04-29 10:37 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-29 10:39 Christoph Hellwig [this message]
2010-04-30 3:13 ` [PATCH] xfstests: fix fiemap-tester when build without fallocate Eric Sandeen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100429103916.GA10535@infradead.org \
--to=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox