From: Christoph Hellwig <hch@infradead.org>
To: Eric Sandeen <sandeen@sandeen.net>
Cc: xfs-oss <xfs@oss.sgi.com>
Subject: Re: [PATCH] xfs: be more explicit if RT mount fails due to config
Date: Fri, 30 Apr 2010 12:40:02 -0400 [thread overview]
Message-ID: <20100430164002.GC14107@infradead.org> (raw)
In-Reply-To: <4BDA54A4.3040204@sandeen.net>
> + if (mp->m_sb.sb_rblocks == 0)
> + return 0;
> + else {
> + cmn_err(CE_WARN, "XFS: Not built with CONFIG_XFS_RT");
> + return ENOSYS;
> + }
No need for the else if you return anyway.
Looks good either way,
Reviewed-by: Christoph Hellwig <hch@lst.de>
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2010-04-30 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-04-30 3:55 [PATCH] xfs: be more explicit if RT mount fails due to config Eric Sandeen
2010-04-30 16:40 ` Christoph Hellwig [this message]
2010-04-30 16:43 ` [PATCH V2] " Eric Sandeen
2010-04-30 16:45 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100430164002.GC14107@infradead.org \
--to=hch@infradead.org \
--cc=sandeen@sandeen.net \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox