From: Dave Chinner <david@fromorbit.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: xfs@oss.sgi.com
Subject: Re: [GIT] Delayed Logging V3
Date: Tue, 4 May 2010 21:44:24 +1000 [thread overview]
Message-ID: <20100504114423.GC8120@dastard> (raw)
In-Reply-To: <20100504101733.GA18229@infradead.org>
On Tue, May 04, 2010 at 06:17:33AM -0400, Christoph Hellwig wrote:
> On Tue, May 04, 2010 at 11:50:42AM +1000, Dave Chinner wrote:
> > The new cleanups added in this version mean it touche?? more files
> > that the previous versions, but overall it should still be simpler
> > to review because I've collapsed many of the intermediate patches
> > into one "Introduce delayed logging core code" commit.
>
> Thanks. Btw, a little procedural comment - you include the V2 markers
> and changelogs in the commit message. Normal procedure is to have
> them below the -- or what it is marker with the diffstat so that they
> only get picked up in the mail and not the final commits, and no V2 in
> the subject line at all.
Yeah, That's typical. The problem is that guilt seems to kill
anything I add to the patch headers below a "---" separator. Hence
if i don't put it the in commit message it doesn't stick as I rebase
my working branches, and hence doesn't get included in the
patchbombs I send direct from the repository.
For stuff that is in a series that I'm tracking in a separate branch I
can probably just keep versioning changes in the series header (the
patch 0/N message), but for individual patches it's a bit harder.
I'll see what I can do to track this more easily in my workflow.
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
prev parent reply other threads:[~2010-05-04 11:42 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-05-04 1:50 [GIT] Delayed Logging V3 Dave Chinner
2010-05-04 10:17 ` Christoph Hellwig
2010-05-04 11:44 ` Dave Chinner [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20100504114423.GC8120@dastard \
--to=david@fromorbit.com \
--cc=hch@infradead.org \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox