Re: [PATCH 11/12] xfs: enable background pushing of the CIL

Christoph Hellwig
2010-05-10T11:43:45Z

On Fri, May 07, 2010 at 03:40:59PM +1000, Dave Chinner wrote:
> From: Dave Chinner <dchinner@redhat.com>
>
> If we let the CIL grow without bound, it will grow large enough to violate
> recovery constraints (must be at least one complete transaction in the log at
> all times) or take forever to write out through the log buffers. Hence we need
> a check during asynchronous transactions as to whether the CIL needs to be
> pushed.
>
> We track the amount of log space the CIL consumes, so it is relatively simple
> to limit it on a pure size basis. Make the limit the minimum of just under half
> the log size (recovery constraint) or 8MB of log space (which is an awful lot
> of metadata).

Looks good except for the use of a cleanup label in xlog_cil_push
mention in the review of the main patch.